Optimize interface code so that the queryentity is called as minimal as possible

RE: Optimize interface code so that the queryentity is called as minimal as possible

Stewart Burchell — Wed, 06 Jan 2021 14:29:04 GMT

You can use the "in" operator rather than the "=" operator for the queryFilter on the field "typevalue". You'll have to make sure that ri!typeValue is an array so you can pass in multiple values.

Again, an observation: you are essentially constructing the same Query Entity based upon different if() conditions. You could make a single Query Entity, use the incoming value of ri!roleType to select the relevant entity cons!, and then use the 'applyWhen' in the filters that only apply conditionally. This will make the code more maintainable and easier to read.

RE: Optimize interface code so that the queryentity is called as minimal as possible

vineethk0001 — Wed, 06 Jan 2021 13:07:55 GMT

if(ri!roleType = "SuperAdmin",
    a!queryEntity(
      entity: cons!CMP_CHART_PROGRAM_CONS,
      query: a!query(
        logicalExpression: a!queryLogicalExpression(
          operator: "AND",
          filters: {
            a!queryFilter(
              field: "programid",
              operator: "=",
              value: ri!programID
            ),
            a!queryFilter(
              field: "type",
              operator: "=",
              value: ri!type
            ),
            a!queryFilter(
              field: "typevalue",
              operator: "=",
              value: ri!typeValue
            ),
          }
        ),
        pagingInfo: a!pagingInfo(startIndex: 1,batchSize: -1)
      ),
      fetchTotalCount: true
    ).data,
    if(ri!roleType = "CL",
        a!queryEntity(
          entity: cons!CMP_CHART_SBG_CONS,
          query: a!query(
            logicalExpression: a!queryLogicalExpression(
              operator: "AND",
              filters: {
                a!queryFilter(
                  field: "programid",
                  operator: "=",
                  value: ri!programID
                ),
                a!queryFilter(
                  field: "type",
                  operator: "=",
                  value: ri!type
                ),
                a!queryFilter(
                  field: "typevalue",
                  operator: "=",
                  value: ri!typeValue
                ),
                a!queryFilter(
                  field: "sbg",
                  operator: "=",
                  value: ri!sbg
                ),
    
    
              }
            ),
            pagingInfo:  a!pagingInfo(startIndex: 1,batchSize: -1)
          ),
          fetchTotalCount: true
        ),
        if(ri!roleType = "NOM",
              a!queryEntity(
                entity: cons!CMP_CHART_NOMINATOR_CONS,
                query: a!query(
                  logicalExpression: a!queryLogicalExpression(
                    operator: "AND",
                    filters: {
                      a!queryFilter(
                        field: "programid",
                        operator: "=",
                        value: ri!programID
                      ),
                      a!queryFilter(
                        field: "type",
                        operator: "=",
                        value: ri!type
                      ),
                      a!queryFilter(
                        field: "typevalue",
                        operator: "=",
                        value: ri!typeValue
                      ),
                      a!queryFilter(
                        field: "nominatoreid",
                        operator: "=",
                        value: ri!nominatorEID
                      ),
      
      
                    }
                  ),
                  pagingInfo: a!pagingInfo(startIndex: 1,batchSize: -1)
                ),
                fetchTotalCount: true
              ),
              if(ri!roleType = "HRG",
                    a!queryEntity(
                      entity: cons!CMP_CHART_HRG_CONS,
                      query: a!query(
                        logicalExpression: a!queryLogicalExpression(
                          operator: "AND",
                          filters: {
                            a!queryFilter(
                              field: "programid",
                              operator: "=",
                              value: ri!programID
                            ),
                            a!queryFilter(
                              field: "type",
                              operator: "=",
                              value: ri!type
                            ),
                            a!queryFilter(
                              field: "typevalue",
                              operator: "=",
                              value: ri!typeValue
                            ),
                            a!queryFilter(
                              field: "hrgeid",
                              operator: "=",
                              value: ri!hrgeid
                            ),
      
      
                          }
                        ),
                        pagingInfo: a!pagingInfo(startIndex: 1,batchSize: -1)
                      ),
                      fetchTotalCount: true
                    ),  
                    null
              )
        )
    )
)

I have attached the code , thank you

RE: Optimize interface code so that the queryentity is called as minimal as possible

Stewart Burchell — Wed, 06 Jan 2021 13:05:01 GMT

If you send me the code for rule!CMP_getChartDataprogramLevel() I can show you what I mean

RE: Optimize interface code so that the queryentity is called as minimal as possible

vineethk0001 — Wed, 06 Jan 2021 13:03:56 GMT

Can you please suggest an example

RE: Optimize interface code so that the queryentity is called as minimal as possible

Stewart Burchell — Wed, 06 Jan 2021 12:37:34 GMT

Your Query Entity needs to be altered to allow the queryFilter to use a list of values for 'typeValue'.

RE: Optimize interface code so that the queryentity is called as minimal as possible

vineethk0001 — Wed, 06 Jan 2021 12:35:43 GMT

Hi Stewart, thanks for the reply, Sorry the Insert code was not working , so have put the code in the body,

using the code example above, am getting the output as List of Variants - 0

but both typevalue 1 and 2 has values, but if I put it together, it gives 0

RE: Optimize interface code so that the queryentity is called as minimal as possible

Stewart Burchell — Wed, 06 Jan 2021 10:22:24 GMT

Hi Vineeth

Firstly, for future reference please use the 'Insert Code' option (under the ;Insert' menu) to add code to these discussions, it retains the formatting and makes it easier for others to review, and copy (if we want to load your code into our own Interface Designer)

A few observations:

this code is way too large and complex. All except one of the 37 local! variables defined are conditional i.e. they have an if() statement around them. Since the if() is handling whether the values of relevant parameters are blank can you not implement this logic inside the rule!CMP_getChartDataprogramLevel() ?
the a!progressBarField() implementation logic looks to me to be the same but with different data - this would benefit from being refactored/abstracted into its own rule
the same can be apllied to the a!richTextDisplayField() - this is also the same each time, but with different data so could become its own parameterised rule HINT: if you find yourself copying/pasting code fragments inside an Interface or Expression Rule and changing values without changing the structure/implementation then that indicates it should be extracted into its own component
I presume the Query Entity is embedded in the rule!CMP_getChartDataprogramLevel() which you are calling 36 times. You may find it better to call this rule once for every combination of the rule inputs across your 36 calls, and then extract the relevant data from the one local! variable. If that's too complicated you could find common groupings of the data and reduce the calls to a smaller number e.g.

rule!CMP_getChartDataprogramLevel(
        roleType: "SuperAdmin",
        programId: ri!programId,
        type: "POC",
        typeValue: {"1", "2"}
      ).data

...and then you can separate the two tranches of data from one local! variable and save yourself a call to the database.

I also notice you're wrapping the entire implementation in a with(). This means ALL of your local! variables will be reloaded, even if they don't need to be e.g. if the value of ri!sbg changes, only those local! variables that are loaded from calls to rule!CMP_getChartDataprogramLevel() that use ri!sbg should be re-loaded. The others can retain the data they've already been loaded with. You can use the a!refreshVariable() to control what gets re-loaded under which changes in ri! values